EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

> in underlying_type.pass.cpp, I'm simply marking the affected static_asserts 
> as libcxx-specific (this probably won't be sufficient when you try to get the 
> Clang/LLVM/libcxx stack running on Windows). In make_signed.pass.cpp and 
> make_unsigned.pass.cpp, I'm giving the enum an explicitly specified 
> underlying type, so the tests below can remain unaffected.


I think it would be better to check if we are on Windows, and test for the 
respected result accordingly.


https://reviews.llvm.org/D22017



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to