craig.topper added inline comments.
================
Comment at: llvm/lib/Target/X86/X86InstrSSE.td:8118
+let Predicates = [HasCMPCCXADD, In64BitMode], Constraints = "$dstsrc2 = $dst"
in
+multiclass CMPCCXADD_BASE<bits<8> Opc, string OpcodeStr> {
----------------
craig.topper wrote:
> This feels like it belongs somewhere other than X86InstrSSE.td since it's not
> vector related.
Missing `Defs = [EFLAGS]` I think
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135933/new/
https://reviews.llvm.org/D135933
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
