shchenz accepted this revision. shchenz added a comment. This revision is now accepted and ready to land.
LGTM. Thanks. ================ Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:588 + else if (A->getOption().matches(options::OPT_ggdb) || + Args.getLastArg(options::OPT_ggdbN_Group)) CmdArgs.push_back( ---------------- nit: maybe we don't need to change this. `OPT_gTune_Group` will check the four debugger types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135908/new/ https://reviews.llvm.org/D135908 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits