isuckatcs marked an inline comment as done.
isuckatcs added inline comments.


================
Comment at: clang/test/Analysis/lambdas.cpp:226
+  [uniquePtr = MakeUniquePtr()] {}();
+  clang_analyzer_warnIfReached(); // expected-warning{{TRUE}}
+}
----------------
steakhal wrote:
> It should have said `REACHABLE`.
> How does this pass? @isuckatcs 
Oh, it's a nice catch. Yes, it should say `REACHABLE` indeed.

Also it seems we didn't get a failing test case because this statement is not 
checked at all. It is inside a block that only runs if the standard is at least 
`c++14`, however the tests are only executed with an `-std=c++11` flag.

I moved these test cases into their own test file in D135965.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131944/new/

https://reviews.llvm.org/D131944

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D131944: [analyzer... Balázs Benics via Phabricator via cfe-commits
    • [PATCH] D131944: [ana... Domján Dániel via Phabricator via cfe-commits

Reply via email to