sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added a subscriber: arphaman.
Herald added a project: All.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
This check performs an extremely large amount of work (for each variable, it
runs very many full matcher-driven traversals of the whole scope the variable
is defined in).
When (inadvertently) enabled for Fuchsia, it regressed BuildAST times by >10x
(400ms -> 7s on my machine).
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D135829
Files:
clang-tools-extra/clangd/TidyProvider.cpp
Index: clang-tools-extra/clangd/TidyProvider.cpp
===================================================================
--- clang-tools-extra/clangd/TidyProvider.cpp
+++ clang-tools-extra/clangd/TidyProvider.cpp
@@ -212,8 +212,14 @@
// code, which is often the case when clangd
// tries to build an AST.
"-bugprone-use-after-move",
- // Alias for bugprone-use-after-moe.
- "-hicpp-invalid-access-moved");
+ // Alias for bugprone-use-after-move.
+ "-hicpp-invalid-access-moved",
+
+ // ----- Performance problems -----
+
+ // This check runs expensive analysis for each variable.
+ // It has been observed to increase reparse time by 10x.
+ "-misc-const-correctness");
size_t Size = BadChecks.size();
for (const std::string &Str : ExtraBadChecks) {
Index: clang-tools-extra/clangd/TidyProvider.cpp
===================================================================
--- clang-tools-extra/clangd/TidyProvider.cpp
+++ clang-tools-extra/clangd/TidyProvider.cpp
@@ -212,8 +212,14 @@
// code, which is often the case when clangd
// tries to build an AST.
"-bugprone-use-after-move",
- // Alias for bugprone-use-after-moe.
- "-hicpp-invalid-access-moved");
+ // Alias for bugprone-use-after-move.
+ "-hicpp-invalid-access-moved",
+
+ // ----- Performance problems -----
+
+ // This check runs expensive analysis for each variable.
+ // It has been observed to increase reparse time by 10x.
+ "-misc-const-correctness");
size_t Size = BadChecks.size();
for (const std::string &Str : ExtraBadChecks) {
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
