erichkeane added a comment. In D134529#3853036 <https://reviews.llvm.org/D134529#3853036>, @ilya-biryukov wrote:
> In D134529#3852990 <https://reviews.llvm.org/D134529#3852990>, @erichkeane > wrote: > >> Note that @BertalanD noticed an issue with what I expect to be this patch: >> https://godbolt.org/z/Wjb9rsEYG >> >> Can someone more knowledgable about this paper please make sure it is an >> intended change? It seems to me that the reversing behavior of the equality >> operators is a little awkward here (note that commenting out != makes that >> 'work' again). > > This is the intended behaviour, yes. The paper aims to revert back to C++17 > behavior when we see a matching `operator !=` and this was an error in C++17: > https://godbolt.org/z/K3cr9MMh5. > As mentioned above, the actual compiler error message is not very helpful and > is something that could be improved, but this was not introduced by this > patch. Thank you very much for clarifying! I wasn't sure, and didn't want to mislead @BertalanD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134529/new/ https://reviews.llvm.org/D134529 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
