inclyc added a comment.

This makes sense! However I think `assert(0)` should not be used in this case, 
we could expose another `llvm_unreachable`-like api and probably 
`llvm_report_error` shall be fine. Are there some changed assertions actually 
"Aspirationally unreachable" in this patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135551/new/

https://reviews.llvm.org/D135551

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to