akyrtzi added a comment. This seems fine to me but note that we no longer depend on the functionality that `test/Index/index-module-with-vfs.m` is testing (and not sure anyone else does), so if there is another change affecting it that is more complicated we could consider removing the test.
================ Comment at: clang/include/clang/Frontend/CompilerInvocation.h:298 +IntrusiveRefCntPtr<llvm::vfs::FileSystem> +createVFSFromOverlayFiles(const std::vector<std::string> &VFSOverlayFiles, + DiagnosticsEngine &Diags, ---------------- The idiomatic LLVM way is to use `ArrayRef` for the parameter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135634/new/ https://reviews.llvm.org/D135634 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
