DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land.
> although those changes don't actually test the code path changed here Yeah I'm just cargo culting on that one so it doesn't look strange that a few are missing. If we're going to change the suffix that can be done elsewhere and reviewed by someone who understands them better than me :) Not crashing is an improvement in itself, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135461/new/ https://reviews.llvm.org/D135461 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits