aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM as well with a diagnostic wording suggestion; please also add a release note for the fix.
================ Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:283 + def err_ms_asm_bitfield_unsupported : Error< + "bit-fields are not supported as operands in inline asm blocks">; + ---------------- (Not strongly tied to the new wording, but we try to write diagnostics in singular form when possible and that led me to this rewording.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135500/new/ https://reviews.llvm.org/D135500 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
