alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thanks!
================
Comment at: clang-rename/USRFinder.h:49
@@ +48,3 @@
+// FIXME: This wouldn't be needed if
+// RecursiveASTVisitor<T>::VisitNestedNameSpecifier would have been
implemented.
+class NestedNameSpecifierLocFinder : public MatchFinder::MatchCallback {
----------------
SG. Please change the comment to `// FIXME: Implement
RecursiveASTVisitor<T>::VisitNestedNameSpecifier instead.`.
================
Comment at: test/clang-rename/ComplicatedClassType.cpp:1-2
@@ -1,5 +1,3 @@
-// Unsupported test.
// RUN: cat %s > %t.cpp
-// FIXME: This test contains very simple constructions likely to be seen in any
-// project and therefore passing this test is a slight sign of success.
-// Currently, the test fails badly.
+// RUN: clang-rename -offset=220 -new-name=Bar %t.cpp -i --
+// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s
----------------
Actually, `cat a > b` is a way to write `cp a b` in lit tests without requiring
a shell. I looked this up and was going to delete the comment, but I've hit
"Hide" instead. Sorry for the noise.
https://reviews.llvm.org/D22465
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
