owenpan added inline comments.
================ Comment at: clang/lib/Format/UnwrappedLineParser.cpp:963 nextToken(/*LevelDifference=*/-AddLevels); HandleVerilogBlockLabel(); ---------------- lahwaacz wrote: > owenpan wrote: > > The `while` loop would address > > https://reviews.llvm.org/D135466#inline-1306331 but is optional IMO because > > it wouldn't distinguish `};;` and the following: > > ``` > > }; > > ; > > ``` > Does it matter? If you have `struct foo {};;` and format it with e.g. > `clang-format --style=LLVM`, you'll get > ``` > struct foo {}; > ; > ``` > so IMO these _should_ be indistinguishible. It might matter when removing the semicolons. We can keep the loop if we have sufficient coverage in test cases. For example, we must ensure that ``` void foo() {}; // ; int bar; ``` is not formatted to ``` void foo() {} // int bar; ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135466/new/ https://reviews.llvm.org/D135466 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
