nickdesaulniers added a comment.

Thanks for the patch, here's the output I observe from the LKML thread 
<https://lore.kernel.org/llvm/20221006222124.aabaemy7ofop7...@google.com/>: 
https://paste.debian.net/1256338/.

I think the stack slot numbers printed at the end aren't correct; the two large 
allocations should be `table`, `540B` which would be Slot 7 and `stack_fds`, 
`256B` which would be Slot 8 in the table.

Expected:

  Variable: stack_fds (line 634 of fs/select.c) in Slot: 8
  Variable: table (line 482 of fs/select.c) in Slot: 7

Actual:

  Variable: stack_fds (line 634 of fs/select.c) in Slot: 3
  Variable: table (line 482 of fs/select.c) in Slot: 2

What does `Fixed` mean? What does it mean for there to be a stack slot that's 
not a `Spill`, but not allocated to a particular variable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135488/new/

https://reviews.llvm.org/D135488

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to