xazax.hun added inline comments.
================
Comment at:
clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:157
+ TopValue &createTop() {
+ return takeOwnership(std::make_unique<TopValue>());
+ }
----------------
gribozavr2 wrote:
> Should we be creating a new top every time, or should it be a singleton like
> true and false?
>
> It seems like we explicitly don't care about its identity (or else it would
> be isomorphic to AtomicBool).
Good point, a singleton Top might actually simplify some parts of the code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135397/new/
https://reviews.llvm.org/D135397
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
