qiongsiwu1 created this revision.
qiongsiwu1 added reviewers: w2yehia, MaskRay, azat, dblaikie.
qiongsiwu1 added projects: clang, LLVM.
Herald added subscribers: ormris, StephenFan, inglorion.
Herald added a project: All.
qiongsiwu1 requested review of this revision.
Herald added subscribers: lldb-commits, cfe-commits.
Herald added a project: LLDB.
https://reviews.llvm.org/D134668 attempted to remove all `--` (double dashes)
when using `plugin-opt` to pass linker options and replaced them with `-`.
https://reviews.llvm.org/D133092 was committed later but introduced an instance
of `--`. This patch replaces the `--` with `-`.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D135400
Files:
clang/lib/Driver/ToolChains/CommonArgs.cpp
clang/test/Driver/debug-options-aranges.c
lldb/cmake/modules/AddLLDB.cmake
Index: lldb/cmake/modules/AddLLDB.cmake
===================================================================
--- lldb/cmake/modules/AddLLDB.cmake
+++ lldb/cmake/modules/AddLLDB.cmake
@@ -105,7 +105,7 @@
# this may result in the wrong install DESTINATION. The FRAMEWORK property
# must be set earlier.
if(PARAM_FRAMEWORK)
- set_target_properties(liblldb PROPERTIES FRAMEWORK ON)
+ set_target_properties(${name} PROPERTIES FRAMEWORK ON)
endif()
if(PARAM_SHARED)
Index: clang/test/Driver/debug-options-aranges.c
===================================================================
--- clang/test/Driver/debug-options-aranges.c
+++ clang/test/Driver/debug-options-aranges.c
@@ -3,4 +3,4 @@
/// Check that the linker plugin will get -generate-arange-section.
// RUN: %clang -### -g --target=x86_64-linux -flto -gdwarf-aranges %s
2>&1 | FileCheck %s
// RUN: %clang -### -g --target=x86_64-linux -flto=thin -gdwarf-aranges %s
2>&1 | FileCheck %s
-// CHECK: --plugin-opt=-generate-arange-section
+// CHECK: -plugin-opt=-generate-arange-section
Index: clang/lib/Driver/ToolChains/CommonArgs.cpp
===================================================================
--- clang/lib/Driver/ToolChains/CommonArgs.cpp
+++ clang/lib/Driver/ToolChains/CommonArgs.cpp
@@ -514,7 +514,7 @@
// the way out.
if (Args.hasArg(options::OPT_gdwarf_aranges)) {
CmdArgs.push_back(
- Args.MakeArgString("--plugin-opt=-generate-arange-section"));
+ Args.MakeArgString("-plugin-opt=-generate-arange-section"));
}
// Try to pass driver level flags relevant to LTO code generation down to
Index: lldb/cmake/modules/AddLLDB.cmake
===================================================================
--- lldb/cmake/modules/AddLLDB.cmake
+++ lldb/cmake/modules/AddLLDB.cmake
@@ -105,7 +105,7 @@
# this may result in the wrong install DESTINATION. The FRAMEWORK property
# must be set earlier.
if(PARAM_FRAMEWORK)
- set_target_properties(liblldb PROPERTIES FRAMEWORK ON)
+ set_target_properties(${name} PROPERTIES FRAMEWORK ON)
endif()
if(PARAM_SHARED)
Index: clang/test/Driver/debug-options-aranges.c
===================================================================
--- clang/test/Driver/debug-options-aranges.c
+++ clang/test/Driver/debug-options-aranges.c
@@ -3,4 +3,4 @@
/// Check that the linker plugin will get -generate-arange-section.
// RUN: %clang -### -g --target=x86_64-linux -flto -gdwarf-aranges %s 2>&1 | FileCheck %s
// RUN: %clang -### -g --target=x86_64-linux -flto=thin -gdwarf-aranges %s 2>&1 | FileCheck %s
-// CHECK: --plugin-opt=-generate-arange-section
+// CHECK: -plugin-opt=-generate-arange-section
Index: clang/lib/Driver/ToolChains/CommonArgs.cpp
===================================================================
--- clang/lib/Driver/ToolChains/CommonArgs.cpp
+++ clang/lib/Driver/ToolChains/CommonArgs.cpp
@@ -514,7 +514,7 @@
// the way out.
if (Args.hasArg(options::OPT_gdwarf_aranges)) {
CmdArgs.push_back(
- Args.MakeArgString("--plugin-opt=-generate-arange-section"));
+ Args.MakeArgString("-plugin-opt=-generate-arange-section"));
}
// Try to pass driver level flags relevant to LTO code generation down to
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
