tbaeder added inline comments.
================
Comment at: clang/lib/AST/Interp/Interp.cpp:421
+bool CastFP(InterpState &S, CodePtr OpPC, const llvm::fltSemantics *Sem) {
+ Floating F = S.Stk.pop<Floating>();
----------------
jcranmer-intel wrote:
> FWIW, `const llvm::fltSemantics &` is the usual way it's used.
I saw, but this is going through a `char[]` stack a gain and I don't think
using a reference works there.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134859/new/
https://reviews.llvm.org/D134859
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
