thieta added a comment.

This looks fine to me in principle. But I wonder if we should land the flag 
change first separately and make sure that no buildbots break because of it. 
Then we can merge the simplification a few days later when we are sure it's 
stabilized, since something similar happened when we upgraded to C++17 - and 
people already had merged code that used C++17 it was really hard to revert.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135128/new/

https://reviews.llvm.org/D135128

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to