serge-sans-paille added inline comments.
================
Comment at: clang/test/CodeGen/bounds-checking-fam.c:2
// REQUIRES: x86-registered-target
-// RUN: %clang_cc1 -emit-llvm -triple x86_64 -fstrict-flex-arrays=0
-fsanitize=array-bounds %s -o - | FileCheck %s
--check-prefixes=CHECK,CHECK-STRICT-0
-// RUN: %clang_cc1 -emit-llvm -triple x86_64 -fstrict-flex-arrays=0
-fsanitize=array-bounds -x c++ %s -o - | FileCheck %s
--check-prefixes=CHECK,CHECK-STRICT-0,CXX,CXX-STRICT-0
-// RUN: %clang_cc1 -emit-llvm -triple x86_64 -fstrict-flex-arrays=1
-fsanitize=array-bounds %s -o - | FileCheck %s
--check-prefixes=CHECK,CHECK-STRICT-1
-// RUN: %clang_cc1 -emit-llvm -triple x86_64 -fstrict-flex-arrays=1
-fsanitize=array-bounds -x c++ %s -o - | FileCheck %s
--check-prefixes=CHECK,CHECK-STRICT-1,CXX
-// RUN: %clang_cc1 -emit-llvm -triple x86_64 -fstrict-flex-arrays=2
-fsanitize=array-bounds %s -o - | FileCheck %s
--check-prefixes=CHECK,CHECK-STRICT-2
-// RUN: %clang_cc1 -emit-llvm -triple x86_64 -fstrict-flex-arrays=2
-fsanitize=array-bounds -x c++ %s -o - | FileCheck %s
--check-prefixes=CHECK,CHECK-STRICT-2,CXX
+// RUN: %clang_cc1 -O2 -emit-llvm -triple x86_64 -fstrict-flex-arrays=0
-fsanitize=array-bounds %s -o - | FileCheck %s
--check-prefixes=CHECK,CHECK-STRICT-0
+// RUN: %clang_cc1 -O2 -emit-llvm -triple x86_64 -fstrict-flex-arrays=0
-fsanitize=array-bounds -x c++ %s -o - | FileCheck %s
--check-prefixes=CHECK,CHECK-STRICT-0,CXX,CXX-STRICT-0
----------------
Why adding -02 here?
================
Comment at: clang/test/CodeGen/object-size-flex-array.c:45
+ // CHECK-STRICT-2: ret i32 -1
+ // CHECK-STRICT-3: ret i32 0
return OBJECT_SIZE_BUILTIN(f->c, 1);
----------------
This one worries me a bit, as an array of size 0 is invalid C, unless you
consider the extension of it being a FAM. Shouldn't we emit a warning or
something here? @kees what meaning would you give to that construct under
`-fstrict-flex-arrays=3` ?
================
Comment at: clang/test/SemaCXX/array-bounds-strict-flex-arrays.cpp:14
// Under -fstrict-flex-arrays={1,2} `a` is not a flexible array
struct t0 {
----------------
update the comment here and below?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134902/new/
https://reviews.llvm.org/D134902
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
