zixuw added a comment.

Ah sorry I just finished reading the discussions. IIUC 
20c9ac29250493f5e0a3791dc1e5e9114ff0dc6e 
<https://reviews.llvm.org/rG20c9ac29250493f5e0a3791dc1e5e9114ff0dc6e> should 
have already fixed the USR generation part, and all of the USR updates in the 
test cases should be gone now?

For the name part (`title`) I believe it's less likely to cause any problem, 
but would still be good to get rid of the location info just for the sake of 
keeping diff working and not having to change lit 🙃 (yeah probably using diff 
was not a good idea in the first place.. 😬)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134813/new/

https://reviews.llvm.org/D134813

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to