beanz added inline comments.
================ Comment at: clang/docs/HLSL/HLSLSupport.rst:98 +``HLSLExternalSemaSource`` will create new decls and use the old decls as +argument for setPreviousDecl. + ---------------- We can probably generalize this to something like: ``` When precompiled headers are used compiling HLSL, the ``ExternalSemaSource`` will be a ``MultiplexExternalSemaSource`` which include both the ``ASTReader`` and ``HLSLExternalSemaSource``. For Built-in declarations that are already completed in the serialized AST, the ``HLSLExternalSemaSource`` will reuse the existing declarations and not introduce new declarations. If the built-in types are not completed in the serialized AST, the ``HLSLExternalSemaSource`` will create new declarations and connect the de-serialized decls as the previous declaration. ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134330/new/ https://reviews.llvm.org/D134330 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
