aaron.ballman added inline comments.
================ Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:31-36 + llvm::sys::path::append(LibPath, "lib64"); if (!llvm::sys::fs::exists(LibPath)) { // In some cases we install bolt binary into one level deeper in bin/, // we need to go back one more level to find lib directory. LibPath = llvm::sys::path::parent_path(llvm::sys::path::parent_path(Dir)); + llvm::sys::path::append(LibPath, "lib64"); ---------------- These changes seem unrelated? ================ Comment at: clang/include/clang/AST/Expr.h:531 + bool isFlexibleArrayMemberLike( + ASTContext &Context, unsigned StrictFlexArraysLevel, + bool IgnoreTemplateOrMacroSubstitution = false) const; ---------------- serge-sans-paille wrote: > aaron.ballman wrote: > > Do we want to make the array levels into an enumeration instead of letting > > the user pass arbitrary integers? (Perhaps not as part of this review.) > Something along https://reviews.llvm.org/D135107 :-) ? LOL and that's why my suggestion seemed so familiar. :-D CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134791/new/ https://reviews.llvm.org/D134791 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits