[PATCH] D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

LGTM



================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:72
+    CmdArgs.push_back(Args.MakeArgString(
+        Twine(PluginOptPrefix) + Twine("-pass-remarks=") + A->getValue()));
 
----------------
Adding `Twine` to one operand of `+` suffices.


================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:76
+    CmdArgs.push_back(Args.MakeArgString(Twine(PluginOptPrefix) +
+                                         Twine("-pass-remarks-missed=") +
+                                         A->getValue()));
----------------
Adding `Twine` to one operand of `+` suffices.


================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:495
+  const bool IsOSAIX = ToolChain.getTriple().isOSAIX();
+
   const char *Linker = Args.MakeArgString(ToolChain.GetLinkerPath());
----------------
delete blank line


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134820/new/

https://reviews.llvm.org/D134820

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits