MaskRay added a comment. > Implement -fctor_dtor_return_this ABI option.
Typo in the subject. I'd use: `Add cc1 option -fctor-dtor-return-this` ================ Comment at: clang/include/clang/Driver/Options.td:5608 +def fctor_dtor_return_this : Flag<["-"], "fctor-dtor-return-this">, + HelpText<"Change the C++ ABI to returning `this` pointer from constructors " + "and non-deleting destructors. (No effect on Microsoft ABI.)">, ---------------- If you use Itanium C++ ABI, it's clear it doesn't change Microsoft ABI. The convention for HelpText is to omit the trailing period. ================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6312 Args.AddLastArg(CmdArgs, options::OPT_malign_double); + Args.AddLastArg(CmdArgs, options::OPT_fctor_dtor_return_this); Args.AddLastArg(CmdArgs, options::OPT_fno_temp_file); ---------------- Clang.cpp handles driver options. Since the option is no longer a driver option, this should be dropped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119209/new/ https://reviews.llvm.org/D119209 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
