martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
Thanks for the updates. I am okay with it now. LGTM. But please wait for NoQ's
approval. So, this is a gentle ping for you @NoQ :)
================
Comment at: clang/test/Analysis/trivial-copy-struct.cpp:61
+void ptr1(List* n) {
+ List* n2 = new List(*n); // cctor
+ if (!n->next) {
----------------
================
Comment at: clang/test/Analysis/trivial-copy-struct.cpp:98
+ // w->head.next and n->next are equal
+ clang_analyzer_warnIfReached(); // expected-warning {{REACHABLE}}
+ }
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134947/new/
https://reviews.llvm.org/D134947
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
