kees marked an inline comment as done.
kees added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3464-3465
+      D.Diag(diag::warn_ignored_clang_option)
+          << "-enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-"
+             "from-clang";
     CmdArgs.push_back(
----------------
nickdesaulniers wrote:
> Rather than open code the string, I wonder if we can use `getLastArg` + 
> `A->getAsString(Args)`?
I went with MaskRay's suggestion, which ultimately does the same thing, just 
without doing it open-coded.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125142/new/

https://reviews.llvm.org/D125142

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to