beanz added inline comments.
================
Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:167
+ for (const auto &Param : Fn->args()) {
+ if (Param.hasStructRetAttr()) {
+ // FIXME: support output.
----------------
python3kgae wrote:
> beanz wrote:
> > I might be missing something, but I'm not seeing a test that exercises the
> > `sret` case.
> Issue https://github.com/llvm/llvm-project/issues/57874 is to track this.
> Cannot create a legal test on compute shader which only has input.
My point is that if this code can't be reached and tested, we shouldn't add it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133983/new/
https://reviews.llvm.org/D133983
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
