jwakely added inline comments.
================
Comment at: libcxx/test/tools/clang_tidy_checks/robust_against_adl.cpp:22
+AST_MATCHER(clang::UnresolvedLookupExpr, isCustomizationPoint) {
+ // TODO: Are make_error_code and make_error_condition actually customization
points?
+ return std::ranges::any_of(
----------------
jwakely wrote:
> Mordante wrote:
> > ldionne wrote:
> > > This is funny, I actually saw a LWG issue about that go by a few weeks
> > > ago. I'll try to get more details.
> > @ldionne @jwakely posted this bug report about it
> > https://github.com/llvm/llvm-project/issues/57614
> They're definitely customization points. If they weren't, specializing
> `is_error_code_enum` and `is_error_condition_enum` would be completely
> useless and serve no purpose.
>
> LWG confirmed that and [LWG 3629](https://wg21.link/lwg3629) is Tentatively
> Ready now.
I created https://reviews.llvm.org/D134943 to fix those customization points.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131963/new/
https://reviews.llvm.org/D131963
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
