MaskRay added a comment.

In D134454#3826143 <https://reviews.llvm.org/D134454#3826143>, @10ne1 wrote:

> In D134454#3824571 <https://reviews.llvm.org/D134454#3824571>, @MaskRay wrote:
>
>> I'll grab an Arch Linux machine for testing, but I don't think this is 
>> currently in a form for submitting.
>> This adds new functionality for non-MIPS and we need some fake file 
>> hierarchies (like those used in `linux-cross.cpp`).
>> I'll add the test, though, and submit this for you.
>>
>> Request changes for now.
>
> Ok. Thanks, please ping if you need any action on my side.

My latest thought is that this patch is going toward a wrong direction: 
https://reviews.llvm.org/D134454#3824630


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134454/new/

https://reviews.llvm.org/D134454

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to