rengolin accepted this revision.
rengolin added a comment.
Looks good, with some nits. Thanks!
================
Comment at: llvm/lib/Target/LoongArch/LoongArchAsmPrinter.cpp:76
+ // TODO: handle extra code.
+ if (!ExtraCode) {
+ const MachineOperand &BaseMO = MI->getOperand(OpNo);
----------------
NIT: Use early exit.
if (ExtraCode)
return false;
================
Comment at: llvm/test/CodeGen/LoongArch/inline-asm-constraint-ZC.ll:16
+;
+; LA64-LABEL: ZC_offset_neg_32769:
+; LA64: # %bb.0:
----------------
Same comment as before, these CHECK lines look identical for both targets...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134638/new/
https://reviews.llvm.org/D134638
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
