dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

SGTM - could you also add some CHECKs in the test that show the enumeration was 
added to the enumerators list on the CU (& you can probably test with just one 
enumerator - don't need two in each test for instance)

& I'm not quite following - what's the difference between the two cases being 
tested? Oh, I guess the second has implicit conversions in the case parameters? 
Fair enough, maybe would benefit from some comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134705/new/

https://reviews.llvm.org/D134705

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to