njames93 added inline comments.
================ Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:2291 Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::VBR, 6)); // LocEnd + Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::VBR, 3)); // Default/DeleteLoc Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::Fixed, 32)); // ODRHash ---------------- aaron.ballman wrote: > Should this be using `6` instead of `3` as with the other location fields? > (`InnerLocStart`, `LocEnd`) And if so, we should probably add some test > coverage for this bit. Whoops, Yes you're right, 6 is above 3 on on number keyboard. Technically it shouldn't make any functional change, just that the field may be expressed in more bits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134549/new/ https://reviews.llvm.org/D134549 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
