jdoerfert added a comment. In D102107#3812582 <https://reviews.llvm.org/D102107#3812582>, @dhruvachak wrote:
> In D102107#3812554 <https://reviews.llvm.org/D102107#3812554>, @dhruvachak > wrote: > >> Updated llvm tests. The following 3 tests still fail: >> >> LLVM :: Transforms/OpenMP/spmdization_constant_prop.ll >> LLVM :: Transforms/OpenMP/spmdization_guarding_two_reaching_kernels.ll >> LLVM :: Transforms/OpenMP/spmdization_remarks.ll > > @jdoerfert @jhuber6 > I updated the LLVM tests except one, > Transforms/OpenMP/spmdization_constant_prop.ll. There is no C source snippet > in there. Can you help as to how to update it? Please review the diffs for > all the updated LLVM tests as well. > > In addition, the other 2 tests above fail even after updating. Looks like > something is wrong. Can you help as to how to fix them? > > Similar to clang tests, we are seeing remarks differences. We already decided > to file an issue (after this patch lands) and look at them after-the-fact. Did you recreate the tests from the C snipped? That is probably not a good idea. We should modify the IR. If we start with C code we can't do it like this anyway. I mean: - the IR is totally different, - the debug info is missing, - lots of unrelated metadata, - part of the device runtime was merged in, - ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
