rnk added a comment.

In D131465#3812387 <https://reviews.llvm.org/D131465#3812387>, @aaron.ballman 
wrote:

> Does `clang-cl` set the `-fms-compatibility` version? If so, then it seems 
> like we'd probably want to key it off `-fms-compatibility`?

I think both driver share the logic for MSVC version detection, which checks 
for cl.exe on PATH and looks at the registry if that fails.

I think we should try to lean towards making this policy easy to document and 
communicate to users, and that means our rules need to be concise. I worry that 
different defaults will surprise cross-platform projects ("hey, my code built 
with on clang Linux, but not Windows with clang-cl, why is that, let's 
debug..."). A simple rule like "clang 16.0 raised the default C++ standard 
version to 17, except on PS4" seems preferable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131465/new/

https://reviews.llvm.org/D131465

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to