yaxunl added a comment. In D134355#3809471 <https://reviews.llvm.org/D134355#3809471>, @b-sumner wrote:
> In D134355#3809294 <https://reviews.llvm.org/D134355#3809294>, @yaxunl wrote: > >> In D134355#3807435 <https://reviews.llvm.org/D134355#3807435>, @cfang wrote: >> >>> LGTM >>> >>> Should the module flag name be amdgpu_code_object_version or >>> amdhsa_code_object_version? >> >> Good question. >> >> @b-sumner Does code object version affects PAL? Thanks. > > It should, we use the same code objects on PAL and ROCm. Thanks. Then amdgpu_code_object_version sounds like the right name. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134355/new/ https://reviews.llvm.org/D134355 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
