jdenny added a comment. It was a small battle to get the tests past the windows bots, but they eventually succeeded:
https://lab.llvm.org/buildbot/#/builders/216/builds/10125 I pushed the following additional patches while trying to fix the tests for windows: - f47a5df92d488bdff418e3b1d249f407885896f2 <https://reviews.llvm.org/rGf47a5df92d488bdff418e3b1d249f407885896f2> - 387924b307ae992cd4bf19908bdd5e4833063ce1 <https://reviews.llvm.org/rG387924b307ae992cd4bf19908bdd5e4833063ce1> - b9735db6464cf0bb4f60077b9f5495c0fa372ecf <https://reviews.llvm.org/rGb9735db6464cf0bb4f60077b9f5495c0fa372ecf> - 88f183c0db71579f06cfca606c333bce7084074e <https://reviews.llvm.org/rG88f183c0db71579f06cfca606c333bce7084074e> b9735db6464cf0bb4f60077b9f5495c0fa372ecf <https://reviews.llvm.org/rGb9735db6464cf0bb4f60077b9f5495c0fa372ecf> adds a fixme and workaround for the issue that `echo` is doubling backslashes under windows. I don't think that's specific to the DEFINE/REDEFINE implementation, and my hunch is that it's not a critical issue. It would take me a while to produce a windows build, so I won't investigate that further anytime soon. If someone else wants to, please feel free. If anything looks objectionable, I can amend further or revert the whole series. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132513/new/ https://reviews.llvm.org/D132513 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
