ab accepted this revision.
ab added a comment.
This revision is now accepted and ready to land.

> but in AArch64TargetParser.def, marking them v8.6 brings in support for the 
> SM4 cryptographic hash and we don't actually have that

Huh, I don't understand why, does that ring a bell?  Looks like it's been there 
since v8.6a was added here;  I asked in D76062 
<https://reviews.llvm.org/D76062>.

Other than that, LGTM; we can go back and change this if we change `V8_6A`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134351/new/

https://reviews.llvm.org/D134351

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to