Author: Chris Bieneman Date: 2022-09-21T10:31:25-05:00 New Revision: bc97751a236e619dc33f81e9fc9b3fe6bd0ba7b6
URL: https://github.com/llvm/llvm-project/commit/bc97751a236e619dc33f81e9fc9b3fe6bd0ba7b6 DIFF: https://github.com/llvm/llvm-project/commit/bc97751a236e619dc33f81e9fc9b3fe6bd0ba7b6.diff LOG: [NFC] Add GitHub issues to HLSL FIXME comments In order to make this easier to track I've filed issues for each of the HLSL FIXME comments that I can find. I may have missed some, but I want this to be the new default mode. Added: Modified: clang/lib/CodeGen/CGHLSLRuntime.cpp clang/lib/Driver/ToolChains/HLSL.cpp clang/lib/Sema/SemaDecl.cpp clang/test/CodeGenHLSL/validator_version.hlsl Removed: ################################################################################ diff --git a/clang/lib/CodeGen/CGHLSLRuntime.cpp b/clang/lib/CodeGen/CGHLSLRuntime.cpp index 8e0088784e548..c61a65813aea5 100644 --- a/clang/lib/CodeGen/CGHLSLRuntime.cpp +++ b/clang/lib/CodeGen/CGHLSLRuntime.cpp @@ -143,6 +143,7 @@ void CGHLSLRuntime::emitEntryFunction(const FunctionDecl *FD, IRBuilder<> B(BB); llvm::SmallVector<Value *> Args; // FIXME: support struct parameters where semantics are on members. + // See: https://github.com/llvm/llvm-project/issues/57874 for (const auto *Param : FD->parameters()) { Args.push_back(emitInputSemantic(B, *Param)); } @@ -150,6 +151,7 @@ void CGHLSLRuntime::emitEntryFunction(const FunctionDecl *FD, CallInst *CI = B.CreateCall(FunctionCallee(Fn), Args); (void)CI; // FIXME: Handle codegen for return type semantics. + // See: https://github.com/llvm/llvm-project/issues/57875 B.CreateRetVoid(); } diff --git a/clang/lib/Driver/ToolChains/HLSL.cpp b/clang/lib/Driver/ToolChains/HLSL.cpp index a80fea2e3efe2..69a7820946246 100644 --- a/clang/lib/Driver/ToolChains/HLSL.cpp +++ b/clang/lib/Driver/ToolChains/HLSL.cpp @@ -209,5 +209,6 @@ HLSLToolChain::TranslateArgs(const DerivedArgList &Args, StringRef BoundArch, } // FIXME: add validation for enable_16bit_types should be after HLSL 2018 and // shader model 6.2. + // See: https://github.com/llvm/llvm-project/issues/57876 return DAL; } diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp index 0f567d91dc81e..865388ccd5fa8 100644 --- a/clang/lib/Sema/SemaDecl.cpp +++ b/clang/lib/Sema/SemaDecl.cpp @@ -11896,6 +11896,7 @@ void Sema::CheckHLSLEntryPoint(FunctionDecl *FD) { for (const auto *Param : FD->parameters()) { if (!Param->hasAttr<HLSLAnnotationAttr>()) { // FIXME: Handle struct parameters where annotations are on struct fields. + // See: https://github.com/llvm/llvm-project/issues/57875 Diag(FD->getLocation(), diag::err_hlsl_missing_semantic_annotation); Diag(Param->getLocation(), diag::note_previous_decl) << Param; FD->setInvalidDecl(); diff --git a/clang/test/CodeGenHLSL/validator_version.hlsl b/clang/test/CodeGenHLSL/validator_version.hlsl index 0d2cbb96dbe48..a3fc4fa1b63c4 100644 --- a/clang/test/CodeGenHLSL/validator_version.hlsl +++ b/clang/test/CodeGenHLSL/validator_version.hlsl @@ -1,6 +1,7 @@ // RUN: %clang -cc1 -S -triple dxil-pc-shadermodel6.3-library -S -emit-llvm -xhlsl -validator-version 1.1 -o - %s | FileCheck %s // FIXME:The following line should work once SPIR-V support for HLSL is added. +// See: https://github.com/llvm/llvm-project/issues/57877 // DISABLED: %clang -cc1 -S -triple spirv32 -S -emit-llvm -xhlsl -validator-version 1.1 -o - %s | FileCheck %s --check-prefix=NOT_DXIL // CHECK:!dx.valver = !{![[valver:[0-9]+]]} _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
