ayzhao added inline comments.
================ Comment at: clang/include/clang/Sema/DeclSpec.h:1918 + /// Lookup result of declarator, if any. + std::unique_ptr<LookupResult> PrevLookupResult; + ---------------- shafik wrote: > Why do we need this one shot previous lookup result? I am struggling to see > the connection between `isDeclaratorFunctionLike(...)` and where we check > `hasPrevLookupResult(...)` and why it matter. Removed ================ Comment at: clang/lib/Sema/DeclSpec.cpp:1502-1504 + LookupResult LR = std::move(*PrevLookupResult); + PrevLookupResult.reset(); + return LR; ---------------- shafik wrote: > Ended up removing `PrevLookupResult` per my other comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
