python3kgae marked an inline comment as done.
python3kgae added inline comments.


================
Comment at: clang/test/CodeGenHLSL/float3.hlsl:1
+// RUN: %clang --driver-mode=dxc -Tlib_6_7 -fcgl  -Fo - %s | FileCheck %s
+
----------------
tahonermann wrote:
> Does this need to use driver mode? That is odd for a code gen test.
Nice catch.
Fixed with 
https://github.com/llvm/llvm-project/commit/8b2f8b309885e872ad98af381ee5459716955877

Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132913/new/

https://reviews.llvm.org/D132913

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to