owenpan added inline comments.

================
Comment at: clang/unittests/Format/FormatTest.cpp:25370
+               "#if 0\n"
+               " if (a) {\n"
+               "#else\n"
----------------
sstwcw wrote:
> Can you confirm that there is supposed to be only one space here while there 
> are two in the next test?  `messUp` turns two spaces into one space.  The 
> formatter doesn't change things inside the `#if 0` block, both before and 
> after D133647.
Good catch. Can you delete this line and line 25383 below when rebasing and 
updating D133647?


================
Comment at: clang/unittests/Format/FormatTest.cpp:25383
+               "#if 0\n"
+               "  if (a) {\n"
+               "#else\n"
----------------
Delete this line when landing D133647.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133635/new/

https://reviews.llvm.org/D133635

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to