barcisz added inline comments.

================
Comment at: clang-tools-extra/test/clang-tidy/check_clang_tidy.py:121
 
+    # Tests should not rely on a certain cuda device being available on the 
machine,
+    # or a certain version of it
----------------
tra wrote:
> The comment is incorrect. These flags have nothing to do with GPU 
> availability, but rather with CUDA SDK which is normally expected to provide 
> the 'standard' set of CUDA headers and libdevice bitcode.
Yes by CUDA I meant cuda library here but I'll change it accordingly


================
Comment at: 
clang-tools-extra/test/clang-tidy/checkers/cuda/unsafe-api-call-function-handler.cu:1
+// (c) Meta Platforms, Inc. and affiliates. Confidential and proprietary.
+
----------------
tra wrote:
> This does not look right. 
Fixed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133804/new/

https://reviews.llvm.org/D133804

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to