yaxunl added inline comments.
================ Comment at: clang/include/clang/Driver/ToolChain.h:719 virtual llvm::SmallVector<BitCodeLibraryInfo, 12> - getHIPDeviceLibs(const llvm::opt::ArgList &Args) const; + getROCmDeviceLibs(const llvm::opt::ArgList &Args) const; ---------------- HIPSPV toolchain is not implemented on ROCm platform. Probably we need to make it even more generic. How about getDeviceLibs ? Also, you need to update the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133726/new/ https://reviews.llvm.org/D133726 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
