beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land.
Two nits, please fix them before merging otherwise looks good. ================ Comment at: clang/include/clang/Driver/Options.td:6941 Group<dxc_Group>, Flags<[DXCOption, NoXarchOption]>, Alias<D>; + def emit_pristine_llvm : DXCFlag<"emit-pristine-llvm">, ---------------- nit: remove extra whitespace change. ================ Comment at: clang/test/Driver/dxc_O.hlsl:11 + +// Make sure Od/O0 option flag which translated into "-O0" "-dxc-opt-disable" +// Od: "-O0" ---------------- nit: out of date comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128845/new/ https://reviews.llvm.org/D128845 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
