mstorsjo added inline comments.
================ Comment at: libcxx/docs/Contributing.rst:119 + +Unless specified otherwise the ``main`` version of Clang is used. + ---------------- Mordante wrote: > aaron.ballman wrote: > > mstorsjo wrote: > > > Mordante wrote: > > > > mstorsjo wrote: > > > > > I don't understand this paragraph - each CI run is run through the > > > > > configured set of supported Clang versions - not only `main`? Or does > > > > > this talk about specifics about manually running tests with the > > > > > Docker image? > > > > This is the version of Clang in the main branch. How about: > > > > `Unless specified otherwise the nightly build of Clang from the > > > > ``main`` branch is used.` > > > I still don't quite understand what this tries to say. "Unless specified > > > otherwise" - where would I specify a different preference, when I upload > > > a patch and it gets run through CI? > > > > > > There's three different concepts involved here: > > > - The CI build matrix (buildkite-pipeline.yml) which specifies a bunch of > > > different versions of tools and standards to run the tests on. Here you > > > can't specify a different preference - all of them are run (unless you > > > edit the file in your patch). > > > - The Docker images, where the default `clang` executable is a recent > > > nightly build, but older releases are available as `clang-<version>` > > > - The `run-buildbot` script, which just uses whatever compiler is set as > > > default (via e.g. the `CXX` env var). > > > > > > So, what about these three concepts is this paragraph trying to say - the > > > second or the third point? This really needs to specify what it talks > > > about - build matrix, docker images or run-buildbot script. > > > > > > The same thing goes for the following paragraph. > > (mostly trying to get rid of the duplicate "Unless specified otherwise".) > I've reworded it, please have a look whether the new wording is clear. Right, that makes it clearer to me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133249/new/ https://reviews.llvm.org/D133249 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
