dblaikie added inline comments.
================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1763-1766
if (Method->isPure())
SPFlags |= llvm::DISubprogram::SPFlagPureVirtual;
else
SPFlags |= llvm::DISubprogram::SPFlagVirtual;
----------------
Seems this change means the virtual/pure virtual flags would be missed for
these virtual-but-not-vtable functions? What does GCC do in terms of debug info
for these functions? (I guess it's not super important/especially material -
since these consteval functions probably can't ever get code generated for
them, so a user can never call them & maybe it's more likely to be good for
debuggers not to think of them as virtual functions (because they might expect
vtable indexes, etc))
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132874/new/
https://reviews.llvm.org/D132874
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
