tschuett added inline comments.
================ Comment at: llvm/lib/Target/AArch64/AArch64GlobalsTagging.cpp:29 + +namespace { + ---------------- I believe you are going too far with the anonymous namespace. There is no need for static functions in anonymous namespaces. https://llvm.org/docs/CodingStandards.html#anonymous-namespaces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133392/new/ https://reviews.llvm.org/D133392 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits