mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1104
if (GV->hasLocalLinkage()) {
GV->setVisibility(llvm::GlobalValue::DefaultVisibility);
return;
----------------
I was wondering if we're changing behaviour in some other case since this is
now checked before the dllexport/dllimport, but I think it shouldn't make any
difference, since we already error out (elsewhere) on dllexport+static today.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133266/new/
https://reviews.llvm.org/D133266
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
