mstorsjo added inline comments.
================ Comment at: clang/www/hacking.html:302 + + <p>For most builds, the pre-commit CI uses a recent + <a href="https://apt.llvm.org/";>nightly build</a> of Clang from LLVM's main ---------------- I'm wondering if there's a better synonym for "builds" here which would be clearer? Initially I read this as if "most times a patch is run through the CI", not "most of the configurations in the CI run". So maybe "configurations"? ================ Comment at: libcxx/docs/Contributing.rst:101 + +Unlike eost parts of the LLVM project, libc++ uses a pre-commit CI [#]_. This +CI is hosted on `Buildkite <https://buildkite.com/llvm-project/libcxx-ci>`__ and ---------------- Typo `eost` - I presume you mean "most"? ================ Comment at: libcxx/docs/Contributing.rst:119 + +Unless specified otherwise the ``main`` version of Clang is used. + ---------------- I don't understand this paragraph - each CI run is run through the configured set of supported Clang versions - not only `main`? Or does this talk about specifics about manually running tests with the Docker image? ================ Comment at: libcxx/docs/Contributing.rst:158 +* ``Clang XX`` these build steps test whether the changes work with all + supported Clang versions. +* ``Booststrapping build`` builds Clang using the revision of the patch and ---------------- Side note - these tests only test one specific version of C++ with these versions of Clang - we don't have fully coverage of all standard versions with all supported versions of Clang. (Not really sure if that's worth mentioning though. Also I do see this kinda hinted at at the end of the file.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133249/new/ https://reviews.llvm.org/D133249 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
