MyDeveloperDay added inline comments.
================
Comment at: clang/docs/ClangFormatStyleOptions.rst:785
+ - Consecutive
+ - AcrossEmptyLines
+ - AcrossComments
----------------
may be AcrossEmptyLines should be a number (to mean the number of empty lines)
================
Comment at: clang/docs/ClangFormatStyleOptions.rst:794
+
+ AlignConsecutiveMacros: AcrossEmptyLines
+
----------------
Should this say `AlignedConsecutuveCommets`
================
Comment at: clang/docs/ClangFormatStyleOptions.rst:797
+ AlignConsecutiveMacros:
+ Enabled: true
+ AcrossEmptyLines: true
----------------
HazardyKnusperkeks wrote:
> MyDeveloperDay wrote:
> > why do we need Enabled?
> >
> > isn't it just
> >
> > ```
> > false:
> > AcrossEmptyLines: false
> > AcrossComments: false
> >
> > true:
> > AcrossEmptyLines: true
> > AcrossComments: true
> > ```
> The struct is a bit older. And we need `Enabled`, one might wish to align
> only really consecutive comments, as the option right now does. (Same for
> macros, assignments, etc..)
I'm still not sure I understand, plus are those use cases you describe tested,
I couldn't see that.
If feels like what you are saying is that AlignConsecutiveStyle is used
elsewhere and it has options that don't pertain to aligning comments?
I couldn't tell if feel like this documentation is describing something other
than AligningTrailingComments, if I'm confused users could be too?
================
Comment at: clang/unittests/Format/FormatTestComments.cpp:2876
+
+ verifyFormat("#include \"a.h\" //\n"
+ "#include \"aa.h\" //\n"
----------------
can we have real comments with different lengths?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132131/new/
https://reviews.llvm.org/D132131
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
