rnk added a subscriber: ayzhao.
rnk added a comment.

In D119051#3747201 <https://reviews.llvm.org/D119051#3747201>, @dblaikie wrote:

> So... my conclusion is that Clang's AArch64 appears to be correct for x86  as 
> well, and we should just rename the function and use it unconditionally, 
> removing any use of Clang's AST POD property in the MSVC ABI handling?

Sounds good to me, I think you did the hard work of verifying, thanks for that. 
:)

Anyway, removing this isPOD usage should be it's own patch, with tests. We 
should already have test coverage for aarch64 that can be reused. @ayzhao, can 
you help David with this? This is not C++20-related, but it is clang frontend 
related.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119051/new/

https://reviews.llvm.org/D119051

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to